Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make npm arg tag_installdataindex optional #20936

Closed
wants to merge 1 commit into from

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Nov 10, 2023

A follow-up to #20829.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This is a pure build change. No QA is required.

@mherrmann mherrmann self-assigned this Nov 10, 2023
@mherrmann mherrmann requested a review from bridiver as a code owner November 10, 2023 04:50
@mherrmann mherrmann enabled auto-merge (squash) November 13, 2023 03:35
@mihaiplesa mihaiplesa requested a review from a team as a code owner July 26, 2024 12:13
@mherrmann mherrmann closed this Aug 7, 2024
auto-merge was automatically disabled August 7, 2024 15:37

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants